0.13.0 #11
Merged
0.13.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgealways
commented
Nov 14, 2021
|
|
||
| this._listenValuePrev = value; | ||
|
|
||
| this.updateDisplay(); | ||
| } |
There was a problem hiding this comment.
I added these checks while testing a three.js example that had an uncheckable checkbox with listen(). I thought listen() was causing the checkbox to lose interactivity by updating the display every frame. The author's intent was actually to disable the controller by using a setter that could ignore assignment calls.
This code appeared to "fix the bug" because the value of input.checked would be allowed to change, while in truth it was out of sync with getValue(), and was never forced to updateDisplay() because the actual value never changed between frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public facing changes: https://github.com/georgealways/lil-gui/blob/dev/Changelog.md#0130
Internal changes:
scripts/tests.jswas getting too big. Now it's split into separate files under thetestsdir._initInputand_initSliderwere cleaned up to be more consistent.